Discussion:
Commit messages
(too old to reply)
Gary Benson
2014-08-08 12:37:38 UTC
Permalink
Hi everyone,

A bunch of commits just got pushed with bad commit messages.
Please be aware that the format for commit messages is:

One-line summary
[blank line]
Description of changes
[blank line]
Copy of the ChangeLog entry/entries

Thanks,
Gary
--
http://gbenson.net/
Doug Evans
2014-08-11 06:12:43 UTC
Permalink
Post by Gary Benson
Hi everyone,
A bunch of commits just got pushed with bad commit messages.
One-line summary
[blank line]
Description of changes
[blank line]
Copy of the ChangeLog entry/entries
Thanks,
Gary
Best get this written down somewhere as an absolute rule.

Maybe any of (or all of) "Contribution Checklist", "Developer Tips" or
"Coding Standards" from the wiki.
[I didn't see it in any of the above, maybe I missed it or maybe it's
elsewhere.]
Gary Benson
2014-08-11 12:24:18 UTC
Permalink
Post by Doug Evans
Post by Gary Benson
A bunch of commits just got pushed with bad commit messages.
One-line summary
[blank line]
Description of changes
[blank line]
Copy of the ChangeLog entry/entries
Best get this written down somewhere as an absolute rule.
Maybe any of (or all of) "Contribution Checklist", "Developer Tips"
or "Coding Standards" from the wiki. [I didn't see it in any of the
above, maybe I missed it or maybe it's elsewhere.]
Actually I think the only time it was mentioned was here:

https://sourceware.org/ml/gdb-patches/2014-01/msg00496.html

I'll update the wiki.

Cheers,
Gary
--
http://gbenson.net/
Gary Benson
2014-08-11 12:39:47 UTC
Permalink
Post by Gary Benson
Post by Doug Evans
Post by Gary Benson
A bunch of commits just got pushed with bad commit messages.
One-line summary
[blank line]
Description of changes
[blank line]
Copy of the ChangeLog entry/entries
Best get this written down somewhere as an absolute rule.
Maybe any of (or all of) "Contribution Checklist", "Developer
Tips" or "Coding Standards" from the wiki. [I didn't see it in
any of the above, maybe I missed it or maybe it's elsewhere.]
https://sourceware.org/ml/gdb-patches/2014-01/msg00496.html
I'll update the wiki.
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages

Cheers,
Gary
--
http://gbenson.net/
Loading...